MARTe2 » MARTe2-core

In Windows there is a clash between String.h and the Windows Strings. It was decided to rename String to StreamString again.

h1. Source code files modified (to solve regression bug).

# modified: Test/Core/BareMetal/L3Streams/IOBufferTest.cpp
# modified: Test/Core/BareMetal/L3Streams/StreamStringTest.cpp

Note: In order to increase the coverage of the StreamStringIOBuffer Printf function, a test with a very long string was added. Given that the same string was also used by the IOBufferTest this has caused one of the tests in IOBuffer to fail (given that the string was larger than the
buffer size). The solution was to change the IOBufferTest to compare the string only up to its BufferSize (as the rest will be correctly
truncated). (see commit f54f02e35afc0c4e6b54ff6f2b58b4bf8820db40)

h1. Source code files modified

# modified: MakeDefaults/Lint/marte_flint_files.lnt
# modified: Source/Core/BareMetal/L0Types/BasicType.h
# modified: Source/Core/BareMetal/L3Streams/IOBuffer.h
# modified: Source/Core/BareMetal/L3Streams/Makefile.inc
# modified: Source/Core/BareMetal/L3Streams/StreamString.cpp
# modified: Source/Core/BareMetal/L3Streams/StreamString.h
# modified: Source/Core/BareMetal/L3Streams/StreamStringIOBuffer.cpp
# modified: Source/Core/BareMetal/L3Streams/StreamStringIOBuffer.h
# modified: Source/Core/FileSystem/L1Portability/BasicFile.h
# modified: Source/Core/FileSystem/L1Portability/Environment/Linux/BasicFile.cpp
# modified: Source/Core/FileSystem/L1Portability/Environment/Linux/BasicFileProperties.h
# modified: Source/Core/FileSystem/L1Portability/Environment/Linux/InternetHost.cpp
# modified: Source/Core/FileSystem/L1Portability/InternetHost.h
# modified: Test/Core/BareMetal/L3Streams/Makefile.inc
# modified: Test/Core/BareMetal/L3Streams/StreamStringIOBufferTest.cpp
# modified: Test/Core/BareMetal/L3Streams/StreamStringIOBufferTest.h
# modified: Test/Core/BareMetal/L3Streams/StreamStringTest.cpp
# modified: Test/Core/BareMetal/L3Streams/StreamStringTest.h
# modified: Test/Core/BareMetal/L3Streams/StreamTestHelper.cpp
# modified: Test/Core/FileSystem/L1Portability/BasicFileTest.cpp
# modified: Test/Core/FileSystem/L1Portability/BasicFileTest.h
# modified: Test/Core/FileSystem/L1Portability/InternetHostTest.cpp
# modified: Test/GTest/Makefile.inc
# modified: Test/GTest/StreamStringGTest.cpp
# modified: Test/GTest/StreamStringIOBufferGTest.cpp

h1. Architecture & design review

*Date of the review:* 16/11/2015

*Person who did the review:* André Neto

*Version of architecture & design document:* N/A. As per the original MARTe implementation.

*Result of review:* N/A

*List of non-conformities:* N/A

h1. Code and documentation review

*Date of the review:* 16/11/2015

*Person who did the review:* R. Vitelli

*Result of review:* PASS

*List of non-conformities:* N/A.

h1. Unit test review

*Date of the review:* 16/11/2015

*Person who did the review:* R. Vitelli

*Result of coverage tests review:* PASS

*Result of functional tests review:* FAIL

*Result of review:* FAIL

*List of non-conformities:*

IOBufferGTest.TestPrintFormattedMultiple fails.