User story #276

Refactor String to StreamString

Added by André Neto over 9 years ago. Updated over 9 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Target version:

0.8

Start date:

16.11.2015

Due date:

% Done:

Estimated time:

Git branch (link):

Git merge to develop (link):

SVN commit (link/?p=rev):

Description

In Windows there is a clash between String.h and the Windows Strings. It was decided to rename String to StreamString again.

Source code files modified (to solve regression bug).¶

modified: Test/Core/BareMetal/L3Streams/IOBufferTest.cpp
modified: Test/Core/BareMetal/L3Streams/StreamStringTest.cpp

Note: In order to increase the coverage of the StreamStringIOBuffer Printf function, a test with a very long string was added. Given that the same string was also used by the IOBufferTest this has caused one of the tests in IOBuffer to fail (given that the string was larger than the
buffer size). The solution was to change the IOBufferTest to compare the string only up to its BufferSize (as the rest will be correctly
truncated). (see commit f54f02e35afc0c4e6b54ff6f2b58b4bf8820db40)

Source code files modified¶

modified: MakeDefaults/Lint/marte_flint_files.lnt
modified: Source/Core/BareMetal/L0Types/BasicType.h
modified: Source/Core/BareMetal/L3Streams/IOBuffer.h
modified: Source/Core/BareMetal/L3Streams/Makefile.inc
modified: Source/Core/BareMetal/L3Streams/StreamString.cpp
modified: Source/Core/BareMetal/L3Streams/StreamString.h
modified: Source/Core/BareMetal/L3Streams/StreamStringIOBuffer.cpp
modified: Source/Core/BareMetal/L3Streams/StreamStringIOBuffer.h
modified: Source/Core/FileSystem/L1Portability/BasicFile.h
modified: Source/Core/FileSystem/L1Portability/Environment/Linux/BasicFile.cpp
modified: Source/Core/FileSystem/L1Portability/Environment/Linux/BasicFileProperties.h
modified: Source/Core/FileSystem/L1Portability/Environment/Linux/InternetHost.cpp
modified: Source/Core/FileSystem/L1Portability/InternetHost.h
modified: Test/Core/BareMetal/L3Streams/Makefile.inc
modified: Test/Core/BareMetal/L3Streams/StreamStringIOBufferTest.cpp
modified: Test/Core/BareMetal/L3Streams/StreamStringIOBufferTest.h
modified: Test/Core/BareMetal/L3Streams/StreamStringTest.cpp
modified: Test/Core/BareMetal/L3Streams/StreamStringTest.h
modified: Test/Core/BareMetal/L3Streams/StreamTestHelper.cpp
modified: Test/Core/FileSystem/L1Portability/BasicFileTest.cpp
modified: Test/Core/FileSystem/L1Portability/BasicFileTest.h
modified: Test/Core/FileSystem/L1Portability/InternetHostTest.cpp
modified: Test/GTest/Makefile.inc
modified: Test/GTest/StreamStringGTest.cpp
modified: Test/GTest/StreamStringIOBufferGTest.cpp

Architecture & design review¶

Date of the review: 16/11/2015

Person who did the review: André Neto

Version of architecture & design document: N/A. As per the original MARTe implementation.

Result of review: N/A

List of non-conformities: N/A

Code and documentation review¶

Date of the review: 16/11/2015

Person who did the review: R. Vitelli

Result of review: PASS

List of non-conformities: N/A.

Unit test review¶

Date of the review: 16/11/2015

Person who did the review: R. Vitelli

Result of coverage tests review: PASS

Result of functional tests review: PASS

Result of review: PASS

List of non-conformities: N/A

Associated revisions

Revision 41524a2d (diff)
Added by André Neto over 9 years ago

#276 Refactored String to StreamString.

Revision f54f02e3 (diff)
Added by André Neto over 9 years ago

#276 solved regression bug in IOBufferTest.cpp

In order to increase the coverage of the StreamStringIOBuffer Printf
function, a test with a very long string was added. Given that the same
string was also used by the IOBufferTest this has caused one of the
tests in IOBuffer to fail (given that the string was larger than the
buffer size). The solution was to change the IOBufferTest to compare the
string only up to its BufferSize (as the rest will be correctly
truncated).