Project

General

Profile

User story #271

Updated by Ivan Herrero over 9 years ago

Generalise the Select implementation from Socket to any generic handle (file descriptor in Linux).

h1. Source code files modified

* Source/Core/FileSystem/L1Portability/Environment/Linux/Select.cpp
* Source/Core/FileSystem/L1Portability/Select.h
* Test/Core/FileSystem/L1Portability/SelectTest.cpp
* Test/Core/FileSystem/L1Portability/SelectTest.h
* Test/GTest/SelectGTest.cpp

h1. Architecture & design review

*Date of the review:* 10/11/2015

*Person who did the review:* André Neto

*Version of architecture & design document:* N/A. As per the original MARTe implementation.

*Result of review:* N/A

*List of non-conformities:* N/A

h1. Code and documentation review

*Date of the review:* 24/11/2015 --/--/2015

*Person who did the review:* Ivan Herrero



*Result of review:* PASS



*List of non-conformities:* N/A N/A.

h1. Unit test review

*Date of the review:* 24/11/2015 --/--/2015

*Person who did the review:* Ivan Herrero -----

*Result of coverage tests review:* PASS [97.0% 131/135] [PASS/FAIL]

*Result of functional tests review:* PASS [92.9% 13/14] [PASS/FAIL]

*Result of review:* PASS [PASS/FAIL]

*List of non-conformities:* N/A

*Comments:* The coverage reports that 13 of 14 functions have been executed, but the class Select has 11 functions and all have been executed.

Back