User story #271
Linux select
0%
Description
Generalise the Select implementation from Socket to any generic handle (file descriptor in Linux).
Source code files modified¶
- Source/Core/FileSystem/L1Portability/Environment/Linux/Select.cpp
- Source/Core/FileSystem/L1Portability/Select.h
- Test/Core/FileSystem/L1Portability/SelectTest.cpp
- Test/Core/FileSystem/L1Portability/SelectTest.h
- Test/GTest/SelectGTest.cpp
Architecture & design review¶
Date of the review: 10/11/2015
Person who did the review: André Neto
Version of architecture & design document: N/A. As per the original MARTe implementation.
Result of review: N/A
List of non-conformities: N/A
Code and documentation review¶
Date of the review: 24/11/2015
Person who did the review: Ivan Herrero
Result of review: PASS
List of non-conformities: N/A
Unit test review¶
Date of the review: 24/11/2015
Person who did the review: Ivan Herrero
Result of coverage tests review: PASS [97.0% 131/135]
Result of functional tests review: PASS [92.9% 13/14]
Result of review: PASS
List of non-conformities: N/A
Comments: The coverage reports that 13 of 14 functions have been executed, but the class Select has 11 functions and all have been executed.
Associated revisions
#271_Linux_select Implementation
Linux select functions implamented, but the files cannnot be compiled
yet, due to a new function of StreamI is required.
#271 Linux select implementation
WIP.
Merge branch 'develop' into #271_Linux_select
#271 Linux Select implementation
- HandleI.h added in ordert to suppor the pure virtual function
GetHandle. - The files compiles, but GetHandle is still not implemented.
- Select class documented.
#271 Linux select implementation
GetHandle() added in BasicFile and BasicSocket
#271 Linux select implementation
Linting done!.
#271 Linux Select implementation
The HandleI::GetHandle() was split in HandleI::GetReadHandle() and
HandleI::GetWriteHandle() due to the BasicConsole has two handles.
The BasicFile, BasicSoket, BasicConsole and Select were modified
accordingly.
#271 Linux select
THe variable highestHandle is updated when WaitUntil is used.
#271 Linux select - unit test implementation WIP
Setup the SelectTest and test started
Merge branch '#271_Linux_select' of https://rvitelli@vcis-gitlab.f4e.europa.eu/aneto/MARTe2.git into #271_Linux_select
#271 Linux select - Test Implementation
Test, test documentation and cover done.
Minor correction done in the WaitUntil.
Merge branch '#271_Linux_select' of
https://vcis-gitlab.f4e.europa.eu/aneto/MARTe2.git into
#271_Linux_select
Conflicts:
Source/Core/FileSystem/L1Portability/Select.h
#271 Linux select - unit test
fixed compilation error related with name variable in the SelectTest
class.
#271 - Minor corrections on comments and code
History
#1 Updated by André Neto over 9 years ago
- Subject changed from Linux generic select to Linux select
#2 Updated by Riccardo Vitelli over 9 years ago
- Assignee set to Llorenc Capella
#3 Updated by Llorenc Capella over 9 years ago
- Status changed from Code: Impl to Code: Rev
#4 Updated by Llorenc Capella over 9 years ago
- Assignee deleted (
Llorenc Capella)
#5 Updated by Riccardo Vitelli over 9 years ago
- Assignee set to Riccardo Vitelli
#6 Updated by Riccardo Vitelli over 9 years ago
- Status changed from Code: Rev to Unit: Impl
#7 Updated by Riccardo Vitelli over 9 years ago
- Assignee changed from Riccardo Vitelli to Llorenc Capella
#8 Updated by Llorenc Capella over 9 years ago
- Status changed from Unit: Impl to Unit: Rev
#9 Updated by Llorenc Capella over 9 years ago
- Assignee deleted (
Llorenc Capella)
#10 Updated by Ivan Herrero over 9 years ago
- Description updated (diff)
- Status changed from Unit: Rev to Closed
The branch #271_Linux_select has been merged on develop (see commit 7b5d3a2).
#271 Linux select
WIP