User story #113
Updated by Ivan Herrero almost 10 years ago
Implement requirement MARTe-EX-F-1.2.11 based on the original MARTe implementation
Note: While waiting for a given event or resource to be available a framework developer might decide to wait and return the control to the operating system schedule.
h1. Source code files modified
* Source\Core\L0Portability\Architecture\x86_cl\HighResolutionTimerA.h
* Source\Core\L0Portability\Architecture\x86_gcc\HighResolutionTimerA.h
* Source\Core\L0Portability\HighResolutionTimer.cpp
* Source\Core\L0Portability\HighResolutionTimer.h
* Source\Core\L0Portability\OperatingSystem\Linux\HighResolutionTimerCalibratorOS.h
* Source\Core\L0Portability\OperatingSystem\Linux\SleepOS.h
* Source\Core\L0Portability\OperatingSystem\Windows\HighResolutionTimerCalibratorOS.h
* Source\Core\L0Portability\OperatingSystem\Windows\SleepOS.h
* Source\Core\L0Portability\Sleep.cpp
* Source\Core\L0Portability\Sleep.h
h1. Architecture & design review
*Date of the review:* 08/06/2015
*Person who did the review:* André Neto
*Version of architecture & design document:* N/A. As per the original MARTe implementation, this is implemented in a support class and does not require formal design in UML.
*Result of review:* N/A
*List of non-conformities:* N/A
h1. Code and documentation review
*Date of the review:* 17/06/2015
*Person who did the review:* Ivan Herrero
*Result of review:* SUCCESS FAIL
*List of non-conformities:* N/A
Manual review for Source\Core\L0Portability\HighResolutionTimer.cpp
In file's documentation it is written HighResolutionTime instead of HighResolutionTimer.
Should the include of INCLUDE_FILE_OPERATING_SYSTEM(OPERATING_SYSTEM,HighResolutionTimerCalibratorOS.h) go to header file?
Is it "HighResolutionTimerCalibratorOS HighResolutionTimer::highResolutionTimerCalibratorOS;" necessary?
Manual review for Source\Core\L0Portability\HighResolutionTimer.h
In file's documentation it is written HighResolutionTime instead of HighResolutionTime.
If the include of INCLUDE_FILE_OPERATING_SYSTEM(OPERATING_SYSTEM,HighResolutionTimerCalibratorOS.h) were here, would the forward declaration of HighResolutionTimerCalibratorOS needed?
*Technical debt:*
Manual review for Source\Core\L0Portability\Architecture\x86_cl\HighResolutionTimerA.h
This file has not been reviewed, because it is pending further discussion.
Manual review for Source\Core\L0Portability\Architecture\x86_gcc\HighResolutionTimerA.h
This file has not been reviewed, because it is pending further discussion.
Manual review for Source\Core\L0Portability\OperatingSystem\Linux\HighResolutionTimerCalibratorOS.h
This file has not been reviewed, because it is pending further discussion.
Manual review for Source\Core\L0Portability\OperatingSystem\Windows\HighResolutionTimerCalibratorOS.h
This file has not been reviewed, because it is pending further discussion.
Note: While waiting for a given event or resource to be available a framework developer might decide to wait and return the control to the operating system schedule.
h1. Source code files modified
* Source\Core\L0Portability\Architecture\x86_cl\HighResolutionTimerA.h
* Source\Core\L0Portability\Architecture\x86_gcc\HighResolutionTimerA.h
* Source\Core\L0Portability\HighResolutionTimer.cpp
* Source\Core\L0Portability\HighResolutionTimer.h
* Source\Core\L0Portability\OperatingSystem\Linux\HighResolutionTimerCalibratorOS.h
* Source\Core\L0Portability\OperatingSystem\Linux\SleepOS.h
* Source\Core\L0Portability\OperatingSystem\Windows\HighResolutionTimerCalibratorOS.h
* Source\Core\L0Portability\OperatingSystem\Windows\SleepOS.h
* Source\Core\L0Portability\Sleep.cpp
* Source\Core\L0Portability\Sleep.h
h1. Architecture & design review
*Date of the review:* 08/06/2015
*Person who did the review:* André Neto
*Version of architecture & design document:* N/A. As per the original MARTe implementation, this is implemented in a support class and does not require formal design in UML.
*Result of review:* N/A
*List of non-conformities:* N/A
h1. Code and documentation review
*Date of the review:* 17/06/2015
*Person who did the review:* Ivan Herrero
*Result of review:* SUCCESS FAIL
*List of non-conformities:* N/A
Manual review for Source\Core\L0Portability\HighResolutionTimer.cpp
In file's documentation it is written HighResolutionTime instead of HighResolutionTimer.
Should the include of INCLUDE_FILE_OPERATING_SYSTEM(OPERATING_SYSTEM,HighResolutionTimerCalibratorOS.h) go to header file?
Is it "HighResolutionTimerCalibratorOS HighResolutionTimer::highResolutionTimerCalibratorOS;" necessary?
Manual review for Source\Core\L0Portability\HighResolutionTimer.h
In file's documentation it is written HighResolutionTime instead of HighResolutionTime.
If the include of INCLUDE_FILE_OPERATING_SYSTEM(OPERATING_SYSTEM,HighResolutionTimerCalibratorOS.h) were here, would the forward declaration of HighResolutionTimerCalibratorOS needed?
*Technical debt:*
Manual review for Source\Core\L0Portability\Architecture\x86_cl\HighResolutionTimerA.h
This file has not been reviewed, because it is pending further discussion.
Manual review for Source\Core\L0Portability\Architecture\x86_gcc\HighResolutionTimerA.h
This file has not been reviewed, because it is pending further discussion.
Manual review for Source\Core\L0Portability\OperatingSystem\Linux\HighResolutionTimerCalibratorOS.h
This file has not been reviewed, because it is pending further discussion.
Manual review for Source\Core\L0Portability\OperatingSystem\Windows\HighResolutionTimerCalibratorOS.h
This file has not been reviewed, because it is pending further discussion.