Project

General

Profile

User story #113

MARTe-EX-F-1.2.11: A framework developer shall be capable of putting the executing thread to sleep for a specified amount of time.

Added by André Neto almost 10 years ago. Updated over 9 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Target version:
0.2
Start date:
Due date:
% Done:

0%

Estimated time:
2.00 h
Git branch (link):
Git merge to develop (link):
SVN commit (link/?p=rev):

Description

Implement requirement MARTe-EX-F-1.2.11 based on the original MARTe implementation

Note: While waiting for a given event or resource to be available a framework developer might decide to wait and return the control to the operating system schedule.

Source code files modified

  • Source\Core\L0Portability\Architecture\x86_cl\HighResolutionTimerA.h
  • Source\Core\L0Portability\Architecture\x86_gcc\HighResolutionTimerA.h
  • Source\Core\L0Portability\HighResolutionTimer.cpp
  • Source\Core\L0Portability\HighResolutionTimer.h
  • Source\Core\L0Portability\OperatingSystem\Linux\HighResolutionTimerCalibratorOS.h
  • Source\Core\L0Portability\OperatingSystem\Linux\SleepOS.h
  • Source\Core\L0Portability\OperatingSystem\Windows\HighResolutionTimerCalibratorOS.h
  • Source\Core\L0Portability\OperatingSystem\Windows\SleepOS.h
  • Source\Core\L0Portability\Sleep.cpp
  • Source\Core\L0Portability\Sleep.h

Architecture & design review

Date of the review: 08/06/2015

Person who did the review: André Neto

Version of architecture & design document: N/A. As per the original MARTe implementation, this is implemented in a support class and does not require formal design in UML.

Result of review: N/A

List of non-conformities: N/A

Code and documentation review

Date of the review: 17/06/2015

Person who did the review: Ivan Herrero

Result of review: SUCCESS

List of non-conformities: N/A

Technical debt:
Manual review for Source\Core\L0Portability\Architecture\x86_cl\HighResolutionTimerA.h
This file has not been reviewed, because it is pending further discussion.

Manual review for Source\Core\L0Portability\Architecture\x86_gcc\HighResolutionTimerA.h
This file has not been reviewed, because it is pending further discussion.

Manual review for Source\Core\L0Portability\OperatingSystem\Linux\HighResolutionTimerCalibratorOS.h
This file has not been reviewed, because it is pending further discussion.

Manual review for Source\Core\L0Portability\OperatingSystem\Windows\HighResolutionTimerCalibratorOS.h
This file has not been reviewed, because it is pending further discussion.

Unit test review

Date of the review: 15/07/2015

Person who did the review: Ivan Herrero

Result of coverage tests review: PASS

Result of functional tests review: PASS

Result of review: PASS

List of non-conformities: N/A

Associated revisions

Revision 2b6bf3ab (diff)
Added by Giuseppe Ferrò almost 10 years ago

Implemented sleep methods.
Implemented HighResolutionTimer counter using intrinsics in windows in order to support 64 bit compiler.
#113

Revision f048da13 (diff)
Added by Giuseppe Ferrò almost 10 years ago

Moved THREADS_DEFAULT_STACKSIZE in GeneralDefinitionsOS.h.
Formatted code with new templates.
Fixed errors accordingly with the revision.
#109 #110 #106 #105 #111 #108 #107 #112 #113 #104 #103

Revision 56f896af (diff)
Added by Giuseppe Ferrò almost 10 years ago

Added Threads and ThreadsDatabase tests.
#110 #123 #103 #104 #112 #107 #108 #111 #106 #105 #109 #113

Revision a1ee0477 (diff)
Added by Giuseppe Ferrò almost 10 years ago

Added Threads unit tests.
Renamed previous tests because they are integration tests.
#110 #123 #103 #104 #112 #107 #108 #111 #106 #105 #109 #113

Revision 88afe86d (diff)
Added by Llorenc Capella over 9 years ago

#122 ProcessorTypeTest modifications & #113 HighREsolutionTimerTest and
SleepTest

List of changes of #122: * Test added in ProcessorTypeTest.cpp * Documentation improvements in ProcessorTypeTest.h * Format ProcessorTypeTest.cpp, ProcessorTypeTest.h, ProcessorTest.cpp

List of changes #113: * Name of the sleep functions modified based on the Ivan comments. * Small modifications in HighResolutionTimer::Counter32. * TestCounter32 input parameter changed in order to avoid overfloat.

Revision 29729b63 (diff)
Added by Llorenc Capella over 9 years ago

US #113 HighResolutionTimerTest modifications

List of changes: * Tolerance function added in TestPeriodFrequency() * Define the tolerance as a function of the input parameter and lower
limit defined for the tolerance. * Files formated.

Revision 674604be (diff)
Added by Ivan Herrero over 9 years ago

#113 - Minor corrections after unit test review

  • Some corrections of format on SleepTest and HighResolutionTimerTest.
  • SleepTest::SleepTest() deleted because it had an empty implementation.
  • SleepTest::TestSec(float32) and SleepGTest::TestSleepSecF deleted
    because target method Sleep::Sec(float32) had been deleted.
  • HighResolutionTimerTest::TestPeriodFrequency() mantained but
    considered an extra test.

Revision 43614e73
Added by Ivan Herrero over 9 years ago

Merge branch 'develop' into #113-UT-review

History

#1 Updated by André Neto almost 10 years ago

  • Subject changed from MARTe-EX-F-1.2.11: A framework developer shall be putting a thread to sleep for a specified amount of time. to MARTe-EX-F-1.2.11: A framework developer shall be capable of putting a thread to sleep for a specified amount of time.

#2 Updated by Riccardo Vitelli almost 10 years ago

  • Subject changed from MARTe-EX-F-1.2.11: A framework developer shall be capable of putting a thread to sleep for a specified amount of time. to MARTe-EX-F-1.2.11: A framework developer shall be capable of putting the executing thread to sleep for a specified amount of time.
  • Target version changed from Backlog to 0.1
  • Start date deleted (29.05.2015)
  • Estimated time set to 2.00 h

#3 Updated by Riccardo Vitelli almost 10 years ago

  • Status changed from New to Arch: Rev

#4 Updated by Riccardo Vitelli almost 10 years ago

  • Assignee set to André Neto

#5 Updated by André Neto almost 10 years ago

  • Description updated (diff)

#6 Updated by Riccardo Vitelli almost 10 years ago

  • Status changed from Arch: Rev to Code: Impl

#7 Updated by Riccardo Vitelli almost 10 years ago

  • Assignee changed from André Neto to Giuseppe Ferro

#8 Updated by Riccardo Vitelli almost 10 years ago

  • Status changed from Code: Impl to Code: Rev

#9 Updated by Riccardo Vitelli almost 10 years ago

  • Assignee changed from Giuseppe Ferro to Ivan Herrero

#10 Updated by Ivan Herrero almost 10 years ago

  • Description updated (diff)

#11 Updated by Ivan Herrero almost 10 years ago

  • Description updated (diff)

#12 Updated by Ivan Herrero almost 10 years ago

  • Assignee changed from Ivan Herrero to Giuseppe Ferro

#13 Updated by Ivan Herrero almost 10 years ago

  • Description updated (diff)

#14 Updated by Ivan Herrero almost 10 years ago

  • Status changed from Code: Rev to Code: Impl

#15 Updated by Riccardo Vitelli almost 10 years ago

  • Status changed from Code: Impl to Code: Rev

#16 Updated by Riccardo Vitelli almost 10 years ago

  • Assignee changed from Giuseppe Ferro to Ivan Herrero

#17 Updated by Ivan Herrero almost 10 years ago

  • Description updated (diff)
  • Assignee deleted (Ivan Herrero)

Code and documentation review passed on revision f7b2aa2. Unit testing implementation pending.

#18 Updated by André Neto almost 10 years ago

  • Status changed from Code: Rev to Unit: Impl

#19 Updated by Riccardo Vitelli almost 10 years ago

  • Status changed from Unit: Impl to Unit: Rev

#20 Updated by Ivan Herrero almost 10 years ago

  • Assignee set to Ivan Herrero

#21 Updated by Ivan Herrero almost 10 years ago

  • Description updated (diff)

Unit test review made on revision 8b64124 [FAIL].

#22 Updated by Ivan Herrero almost 10 years ago

  • Description updated (diff)

#23 Updated by Riccardo Vitelli almost 10 years ago

  • Assignee deleted (Ivan Herrero)

#24 Updated by Riccardo Vitelli almost 10 years ago

  • Status changed from Unit: Rev to Unit: Impl

#25 Updated by Riccardo Vitelli almost 10 years ago

  • Target version changed from 0.1 to 0.2

#26 Updated by Llorenc Capella over 9 years ago

  • Assignee set to Llorenc Capella

#27 Updated by Llorenc Capella over 9 years ago

  • Status changed from Unit: Impl to Unit: Rev

#28 Updated by Llorenc Capella over 9 years ago

  • Assignee deleted (Llorenc Capella)

The functions HighResolutionTimerCalibratorOs::GetInitialTicks & HighResolutionTimerCalibratorOs::GetInitialTime() are not included in the HighReolutionTimer.h.

#29 Updated by Ivan Herrero over 9 years ago

  • Description updated (diff)
  • Assignee set to Ivan Herrero

A unit test review has been done on revision 6072de0 with a result of "PASS".

Some minor corrections after unit test review committed on revision 674604b.

#30 Updated by Riccardo Vitelli over 9 years ago

  • Status changed from Unit: Rev to Closed

#31 Updated by Riccardo Vitelli over 9 years ago

  • Assignee deleted (Ivan Herrero)

Also available in: Atom PDF