Verify and implement coding standard using Flexelint.

Source code files modified¶

• Source/Core/L0Portability/ThreadInformation.cpp
• Source/Core/L0Portability/ThreadInformation.h

Architecture & design review¶

Date of the review: 29/07/2015

Person who did the review: Ivan Herrero

Version of architecture & design document: N/A. As per the original MARTe implementation, this is a support function and does not require formal design in UML.

Result of review: N/A

List of non-conformities: N/A

Code and documentation review¶

Date of the review: 29/07/2015

Person who did the review: Ivan Herrero

Result of review: PASS (MISRA non compliant)

List of non-conformities:

• MARTe2-dev/Source/Core/L0Portability/ThreadInformation.h:47:25: Note 9109: type 'ThreadInformation' previously declared at location 'line 47' [MISRA C++ Rule 3-2-3]
• MARTe2-dev/Source/Core/L0Portability/ThreadInformation.cpp:93:49: Note 929: cast from pointer to pointer [MISRA C++ Rule 5-2-7]
• MARTe2-dev/Source/Core/L0Portability/ThreadInformation.h:47:25: Note 9109: type 'ThreadInformation' previously declared at location 'line 47' [MISRA C++ Rule 3-2-3]
• MARTe2-dev/Source/Core/L0Portability/ThreadInformation.h:47:25: Note 9109: type 'ThreadInformation' previously declared at location 'line 47' [MISRA C++ Rule 3-2-3]
• Warning 459: Function 'SystemThreadFunction(ThreadInformation *)' whose address was taken has an unprotected access to variable 'ThreadsDatabase::maxNOfEntries'
• Warning 459: Function 'SystemThreadFunction(ThreadInformation *)' whose address was taken has an unprotected access to variable 'ThreadsDatabase::nOfEntries'
• Warning 459: Function 'SystemThreadFunction(ThreadInformation *)' whose address was taken has an unprotected access to variable 'ThreadsDatabase::entries'
• Warning 459: Function 'SystemThreadFunction(ThreadInformation *)' whose address was taken has an unprotected access to variable 'ThreadsDatabase::internalMutex'

Unit test review¶

Date of the review: 29/07/2015

Person who did the review: Ivan Herrero

Result of coverage tests review: PASS

Result of functional tests review: N/A

Result of review: FAIL

List of non-conformities:

ThreadInformation class has not specific unit tests, but it is actually tested through the unit tests of ThreadInformation class.