Requirements review¶

Date of the review: 09/12/2015

Person who did the review: Ivan Herrero

Version of requirements: 0.9

Result of review: N/A

List of non-conformities: N/A

Comments: As per the original MARTe implementation, the user stories of this sprint are support functions and do not require formal requirements.

Architecture & design review¶

Date of the review: 09/12/2015

Person who did the review: Ivan Herrero

Version of architecture & design document: 0.9

Result of review: N/A

List of non-conformities: N/A

Comments: As per the original MARTe implementation, the user stories of this sprint are support functions and do not require formal design.

Code and documentation review¶

Date of the review: 09/12/2015

Person who did the review: Ivan Herrero

Version of source code: 0.9

Result of review: PASS

List of non-conformities:

• #248 - Documentation of LocalHostInfo in InternetHost.cpp is missing both in Linux and Windows
• #275 - As a pattern DirectoryScanner should use LinkedListHolder and not inherit from it.
• #279 - A new user story (#286) has been added for fixing pending lint errors.

Unit test review¶

Date of the review: 09/12/2015

Person who did the review: Ivan Herrero

Version of unit tests: 0.9

Result of coverage tests review: PASS

Result of functional tests review: PASS

Result of review: PASS

List of non-conformities:

• #248 - It is not clear if the HeapManager.TestFreeInvalidPointer crashes in Windows (a user-story to handle this has to be created)

• #248
  The following list of tests (unrelated to this user-story fail):
  [ FAILED ] 9 tests, listed below:
  [ FAILED ] BasicFileGTest.TestOpen_FLAG_CREAT_EXCLUSIVE
  [ FAILED ] ThreadsGTest.TestBeginThreadStacksize0
  [ FAILED ] MutexSemGTest.TestIsRecursive
  [ FAILED ] MutexSemGTest.TestRecursiveOff
  [ FAILED ] LoadableLibraryGTest.TestOpenCloseLibrary
  [ FAILED ] LoadableLibraryGTest.TestCloseLibrary
  [ FAILED ] LoadableLibraryGTest.TestLoadFunction
  [ FAILED ] LoadableLibraryGTest.TestLoadFunctionSquareBracketsOperator
  [ FAILED ] LoadableLibraryGTest.TestGetModule

• #275
  Some tests have failed, but the user story has been accepted.
  [ FAILED ] DirectoryGTest.TestGetLastAccessTime_ReRead
  [ FAILED ] DirectoryGTest.TestGetLastAccessTime_ReRead2
  [ FAILED ] DirectoryGTest.TestScanFilter
  Randome failures in TestScanFilter to be investigated.
  These two tests require http://www.groovypost.com/howto/microsoft/enable-last-access-time-stamp-to-files-folder-windows-7/ to be setup (but it needs admin rights)
  [ FAILED ] BasicTCPSocketGTest.TestConnect
  [ FAILED ] BasicTCPSocketGTest.TestRead
  These tests fail randomly and seem to be associated to the quantity of open sockets (to be investigated in a later user-story).

• #278
  Note 1: It compiles on Linux with all tests, but on Windows it is necessary to deactivate the DirectoryScannerTest, DirectoryTest, SelectTest, DirectoryScannerGTest, DirectoryGTest, and SelectGTest.
  Note 2: The execution of the unit tests on Windows reports the following issues:
  [ FAILED ] HighResolutionTimerGTest.TestGetTimeStamp
  [ FAILED ] LoadableLibraryGTest.TestOpenCloseLibrary
  [ FAILED ] LoadableLibraryGTest.TestCloseLibrary
  [ FAILED ] LoadableLibraryGTest.TestLoadFunction
  [ FAILED ] LoadableLibraryGTest.TestLoadFunctionSquareBracketsOperator
  [ FAILED ] LoadableLibraryGTest.TestGetModule
  [ FAILED ] MutexSemGTest.TestIsRecursive
  [ FAILED ] MutexSemGTest.TestRecursiveOff
  [ FAILED ] ThreadsGTest.TestBeginThreadStacksize0

Integration test review¶

Date of the review: 09/12/2015

Person who did the review: Ivan Herrero

Version of integration tests: 0.9

Result of review: N/A

List of non-conformities: N/A

Comments: As per the original MARTe implementation, the user stories of this sprint are support functions and do not require formal integration tests.

Acceptance test review¶

Date of the review: 09/12/2015

Person who did the review: Ivan Herrero

Version of acceptance tests: 0.9

Result of review: N/A

List of non-conformities: N/A

Comments: As per the original MARTe implementation, the user stories of this sprint are support functions and do not require formal acceptance tests.