User story #622
Merge NI1588 modifications (from FAT tools)
0%
History
#1 Updated by André Neto about 4 years ago
- Status changed from New to Code: Impl
#2 Updated by André Neto about 4 years ago
- Assignee set to Pedro Lourenco
#3 Updated by André Neto almost 4 years ago
- Status changed from Code: Impl to Unit: Rev
#4 Updated by André Neto almost 4 years ago
- Assignee changed from Pedro Lourenco to André Neto
#5 Updated by André Neto almost 4 years ago
- Status changed from Unit: Rev to Code: Impl
#6 Updated by André Neto almost 4 years ago
- Assignee changed from André Neto to Pedro Lourenco
#7 Updated by Pedro Lourenco almost 4 years ago
- File lcov_ni1588_noHW_06042021.txt lcov_ni1588_noHW_06042021.txt added
- File NI1588_noHW_06042021.qahelper.redmine.txt NI1588_noHW_06042021.qahelper.redmine.txt added
- File NI1588_noHW_06042021.qahelper.html NI1588_noHW_06042021.qahelper.html added
Due to the absence of the NI hardware, the PrepareNextState and DriverRead method related tests fail. These will be refactored when the setup is prepared.
Adding QA temporary reports:
- NI1588_noHW_06042021.qahelper.html
- NI1588_noHW_06042021.qahelper.redmine.txt
- lcov_ni1588_noHW_06042021.txt (run separately)
QAHelper Output
DESCRIBE CHANGES TODO
General
Information
The following files were detected as changed between branches #622_Merge_NI1588 and develop Source/Components/DataSources/NI1588/NI1588Timestamp.cpp Source/Components/DataSources/NI1588/NI1588Timestamp.h Test/Components/DataSources/NI1588/NI1588TimestampGTest.cpp Test/Components/DataSources/NI1588/NI1588TimestampTest.cpp Test/Components/DataSources/NI1588/NI1588TimestampTest.h
OK: no errors found.
Requirements review¶
Date of the review: 06/04/2021
Person who did the review: TODO
Version of requirements: TODO
Result of review: TODO
List of non-conformities: TODO
Comments: TODO
Architecture & design review¶
Date of the review: 06/04/2021
Person who did the review: TODO
Version of architecture & design document: TODO
Result of review: TODO
List of non-conformities: TODO
Comments: TODO
Code and documentation review¶
Date of the review: 06/04/2021
Person who did the review: TODO
Version of source code: c9cb11171f7d139aa8ec78d8d82a0c40ab5bd9e2
Result of review: TODO
List of non-conformities:
Run flexelint and report TODO
Headers
OK: All headers are correctly formatted
OK: no errors found.
Lint includes
OK: All files are being included for linting
OK: no errors found.
Linter
ERR: /home/codac-dev/MARTe2-dev/MakeDefaults/Lint/marte_flint_exceptions.lnt 15
ERR: Lint/marte_components_flint_files.lnt:114:1: Error 305: Unable to open module 'EventConditionTrigger.cpp'
Doxygen
ERR: warning: source ./Docs/Assets/Snippets/Parsing/MathGrammar.ll is not a readable file or directory... skipping.
ERR: /home/codac-dev/ni9157Testing/MARTe2-components/Source/Components/Interfaces/OPCUA/OPCUATypes.h:45: warning: Compound OPCUA::NodeProperties is not documented.
ERR: /home/codac-dev/ni9157Testing/MARTe2-components/Source/Components/Interfaces/OPCUA/OPCUATypes.h:60: warning: Compound OPCUA::ObjectProperties is not documented.
ERR: /home/codac-dev/ni9157Testing/MARTe2-components/Source/Components/Interfaces/EPICSPVA/EPICSPVAStructureDataI.h:354: warning: Member EPICSPVAStructureDataI::ReadArray< std::string >(epics::pvData::PVScalarArrayPtr scalarArrayPtr, AnyType &storedType, const AnyType &value) (function) of namespace MARTe is not documented.
ERR: /home/codac-dev/ni9157Testing/MARTe2-components/Source/Components/Interfaces/EPICSPVA/EPICSPVAStructureDataI.h:417: warning: Member EPICSPVAStructureDataI::WriteArray< std::string >(epics::pvData::PVScalarArrayPtr scalarArrayPtr, AnyType &storedType, const AnyType &value, const uint32 &size) (function) of namespace MARTe is not documented.
ERR: /home/codac-dev/ni9157Testing/MARTe2-components/Source/Components/Interfaces/OPCUA/OPCUATypes.h:54: warning: Member OPCUANodeSettings (typedef) of namespace OPCUA is not documented.
ERR: /home/codac-dev/ni9157Testing/MARTe2-components/Source/Components/Interfaces/OPCUA/OPCUATypes.h:68: warning: Member OPCUAObjectSettings (typedef) of namespace OPCUA is not documented.
ERR: /home/codac-dev/ni9157Testing/MARTe2-components/Source/Components/DataSources/OPCUADataSource/README.md:21: warning: explicit link request to 'include(CheckIPOSupported)' could not be resolved
ERR: /home/codac-dev/ni9157Testing/MARTe2-components/Source/Components/DataSources/OPCUADataSource/README.md:22: warning: explicit link request to 'check_ipo_supported(RESULT CC_HAS_IPO)' could not be resolved
ERR: /home/codac-dev/ni9157Testing/MARTe2-components/Source/Components/DataSources/OPCUADataSource/README.md:23: warning: explicit link request to 'if(CC_HAS_IPO)' could not be resolved
ERR: /home/codac-dev/ni9157Testing/MARTe2-components/Source/Components/DataSources/OPCUADataSource/README.md:25: warning: explicit link request to 'endif()' could not be resolved
ERR: /home/codac-dev/ni9157Testing/MARTe2-components/Source/Components/DataSources/OPCUADataSource/README.md:28: warning: found </c> at different nesting level (5) than expected (2)
ERR: /home/codac-dev/ni9157Testing/MARTe2-components/Source/Components/DataSources/OPCUADataSource/README.md:29: warning: found </c> at different nesting level (5) than expected (2)
ERR: /home/codac-dev/ni9157Testing/MARTe2-components/Source/Components/DataSources/OPCUADataSource/README.md:42: warning: end of comment block while expecting command
ERR: /home/codac-dev/ni9157Testing/MARTe2-components/Source/Components/DataSources/ProfinetDataSource/Docs/README.md:112: warning: Unsupported xml/html tag <DeviceIdentity> found
ERR: /home/codac-dev/ni9157Testing/MARTe2-components/Source/Components/DataSources/ProfinetDataSource/Docs/README.md:113: warning: Unsupported xml/html tag <InfoText> found
ERR: /home/codac-dev/ni9157Testing/MARTe2-components/Source/Components/DataSources/ProfinetDataSource/Docs/README.md:114: warning: Unsupported xml/html tag <VendorName> found
ERR: /home/codac-dev/ni9157Testing/MARTe2-components/Source/Components/DataSources/ProfinetDataSource/Docs/README.md:115: warning: Unsupported xml/html tag </DeviceIdentity> found
ERR: /home/codac-dev/ni9157Testing/MARTe2-components/Source/Components/DataSources/ProfinetDataSource/Docs/README.md:286: warning: Unsupported xml/html tag <osal> found
ERR: /home/codac-dev/ni9157Testing/MARTe2-components/Source/Components/DataSources/LoggerDataSource/LoggerBroker.h:76: warning: Member SetPeriod(const uint32 cyclePeriodIn) (function) of class MARTe::LoggerBroker is not documented.
ERR: /home/codac-dev/ni9157Testing/MARTe2-components/Source/Components/DataSources/LoggerDataSource/LoggerDataSource.h:68: warning: Member Initialise(StructuredDataI &data) (function) of class MARTe::LoggerDataSource is not documented.
ERR: /home/codac-dev/ni9157Testing/MARTe2-components/Source/Components/DataSources/OPCUADataSource/OPCUAClientMethod.h:90: warning: argument 'nodePaths' of command @param is not found in the argument list of MARTe::OPCUAClientMethod::SetMethodRequest(const uint16 methodNamespaceIndex, StreamString methodPath)
ERR: /home/codac-dev/ni9157Testing/MARTe2-components/Source/Components/DataSources/OPCUADataSource/OPCUAClientMethod.h:90: warning: The following parameters of MARTe::OPCUAClientMethod::SetMethodRequest(const uint16 methodNamespaceIndex, StreamString methodPath) are not documented:
ERR: /home/codac-dev/ni9157Testing/MARTe2-components/Source/Components/DataSources/OPCUADataSource/OPCUAClientMethod.h:79: warning: argument 'nodePaths' of command @param is not found in the argument list of MARTe::OPCUAClientMethod::SetObjectRequest(const uint16 methodNamespaceIndex, StreamString methodPath)
ERR: /home/codac-dev/ni9157Testing/MARTe2-components/Source/Components/DataSources/OPCUADataSource/OPCUAClientMethod.h:79: warning: The following parameters of MARTe::OPCUAClientMethod::SetObjectRequest(const uint16 methodNamespaceIndex, StreamString methodPath) are not documented:
ERR: /home/codac-dev/ni9157Testing/MARTe2-components/Source/Components/DataSources/ProfinetDataSource/ProfinetDataSource.h:339: warning: expected <li> tag but found TK_LNKWORD token instead!
ERR: /home/codac-dev/ni9157Testing/MARTe2-components/Source/Components/DataSources/ProfinetDataSource/ProfinetDataSource.h:622: warning: unexpected end of comment while inside <ul> block
ERR: /home/codac-dev/ni9157Testing/MARTe2-components/Source/Components/GAMs/SimulinkWrapperGAM/SimulinkClasses.h:122: warning: The following parameters of MARTe::SimulinkDataI::PrintData(const uint64 maxNameLength=0u, StreamString additionalText="") are not documented:
ERR: /home/codac-dev/ni9157Testing/MARTe2-components/Source/Components/GAMs/SimulinkWrapperGAM/SimulinkClasses.h:269: warning: Member runningOffset (variable) of class MARTe::SimulinkPort is not documented.
ERR: /home/codac-dev/ni9157Testing/MARTe2-components/Source/Components/GAMs/SimulinkWrapperGAM/SimulinkClasses.h:270: warning: Member typeBasedSize (variable) of class MARTe::SimulinkPort is not documented.
ERR: /home/codac-dev/ni9157Testing/MARTe2-components/Source/Components/GAMs/SimulinkWrapperGAM/SimulinkClasses.h:271: warning: Member offsetBasedSize (variable) of class MARTe::SimulinkPort is not documented.
ERR: /home/codac-dev/ni9157Testing/MARTe2-components/Source/Components/GAMs/SimulinkWrapperGAM/SimulinkClasses.h:272: warning: Member CAPISize (variable) of class MARTe::SimulinkPort is not documented.
ERR: /home/codac-dev/ni9157Testing/MARTe2-components/Source/Components/GAMs/SimulinkWrapperGAM/SimulinkClasses.h:274: warning: Member baseAddress (variable) of class MARTe::SimulinkPort is not documented.
ERR: /home/codac-dev/ni9157Testing/MARTe2-components/Source/Components/GAMs/SimulinkWrapperGAM/SimulinkClasses.h:275: warning: Member lastSignalAddress (variable) of class MARTe::SimulinkPort is not documented.
ERR: /home/codac-dev/ni9157Testing/MARTe2-components/Source/Components/GAMs/SimulinkWrapperGAM/SimulinkClasses.h:291: warning: explicit link request to 'offsetBasedSize' could not be resolved
ERR: /home/codac-dev/ni9157Testing/MARTe2-components/Source/Components/GAMs/SimulinkWrapperGAM/SimulinkClasses.h:269: warning: Member runningOffset (variable) of class MARTe::SimulinkPort is not documented.
ERR: /home/codac-dev/ni9157Testing/MARTe2-components/Source/Components/GAMs/SimulinkWrapperGAM/SimulinkClasses.h:270: warning: Member typeBasedSize (variable) of class MARTe::SimulinkPort is not documented.
ERR: /home/codac-dev/ni9157Testing/MARTe2-components/Source/Components/GAMs/SimulinkWrapperGAM/SimulinkClasses.h:271: warning: Member offsetBasedSize (variable) of class MARTe::SimulinkPort is not documented.
ERR: /home/codac-dev/ni9157Testing/MARTe2-components/Source/Components/GAMs/SimulinkWrapperGAM/SimulinkClasses.h:272: warning: Member CAPISize (variable) of class MARTe::SimulinkPort is not documented.
ERR: /home/codac-dev/ni9157Testing/MARTe2-components/Source/Components/GAMs/SimulinkWrapperGAM/SimulinkClasses.h:274: warning: Member baseAddress (variable) of class MARTe::SimulinkPort is not documented.
ERR: /home/codac-dev/ni9157Testing/MARTe2-components/Source/Components/GAMs/SimulinkWrapperGAM/SimulinkClasses.h:275: warning: Member lastSignalAddress (variable) of class MARTe::SimulinkPort is not documented.
ERR: /home/codac-dev/ni9157Testing/MARTe2-components/Source/Components/GAMs/SimulinkWrapperGAM/SimulinkClasses.h:269: warning: Member runningOffset (variable) of class MARTe::SimulinkPort is not documented.
ERR: /home/codac-dev/ni9157Testing/MARTe2-components/Source/Components/GAMs/SimulinkWrapperGAM/SimulinkClasses.h:270: warning: Member typeBasedSize (variable) of class MARTe::SimulinkPort is not documented.
ERR: /home/codac-dev/ni9157Testing/MARTe2-components/Source/Components/GAMs/SimulinkWrapperGAM/SimulinkClasses.h:271: warning: Member offsetBasedSize (variable) of class MARTe::SimulinkPort is not documented.
ERR: /home/codac-dev/ni9157Testing/MARTe2-components/Source/Components/GAMs/SimulinkWrapperGAM/SimulinkClasses.h:272: warning: Member CAPISize (variable) of class MARTe::SimulinkPort is not documented.
ERR: /home/codac-dev/ni9157Testing/MARTe2-components/Source/Components/GAMs/SimulinkWrapperGAM/SimulinkClasses.h:274: warning: Member baseAddress (variable) of class MARTe::SimulinkPort is not documented.
ERR: /home/codac-dev/ni9157Testing/MARTe2-components/Source/Components/GAMs/SimulinkWrapperGAM/SimulinkClasses.h:275: warning: Member lastSignalAddress (variable) of class MARTe::SimulinkPort is not documented.
ERR: /home/codac-dev/ni9157Testing/MARTe2-components/Source/Components/GAMs/StatisticsGAM/StatisticsHelperT.h:323: warning: Member Reset() (function) of class MARTe::StatisticsHelperT is not documented.
ERR: /home/codac-dev/ni9157Testing/MARTe2-components/Source/Components/GAMs/StatisticsGAM/StatisticsHelperT.h:399: warning: Member StatisticsHelperT(const uint32 windowSize) (function) of class MARTe::StatisticsHelperT is not documented.
ERR: /home/codac-dev/ni9157Testing/MARTe2-components/Source/Components/GAMs/StatisticsGAM/StatisticsHelperT.h:420: warning: Member StatisticsHelperT(const uint32 windowSize) (function) of class MARTe::StatisticsHelperT is not documented.
ERR: /home/codac-dev/ni9157Testing/MARTe2-components/Source/Components/GAMs/StatisticsGAM/StatisticsHelperT.h:626: warning: Member GetAvg() const (function) of class MARTe::StatisticsHelperT is not documented.
ERR: /home/codac-dev/ni9157Testing/MARTe2-components/Source/Components/GAMs/StatisticsGAM/StatisticsHelperT.h:636: warning: Member GetAvg() const (function) of class MARTe::StatisticsHelperT is not documented.
ERR: /home/codac-dev/ni9157Testing/MARTe2-components/Source/Components/Interfaces/OPCUA/OPCUATypes.h:46: warning: Member attr (variable) of class OPCUA::NodeProperties is not documented.
ERR: /home/codac-dev/ni9157Testing/MARTe2-components/Source/Components/Interfaces/OPCUA/OPCUATypes.h:47: warning: Member value (variable) of class OPCUA::NodeProperties is not documented.
ERR: /home/codac-dev/ni9157Testing/MARTe2-components/Source/Components/Interfaces/OPCUA/OPCUATypes.h:48: warning: Member nodeId (variable) of class OPCUA::NodeProperties is not documented.
ERR: /home/codac-dev/ni9157Testing/MARTe2-components/Source/Components/Interfaces/OPCUA/OPCUATypes.h:49: warning: Member nodeName (variable) of class OPCUA::NodeProperties is not documented.
ERR: /home/codac-dev/ni9157Testing/MARTe2-components/Source/Components/Interfaces/OPCUA/OPCUATypes.h:50: warning: Member parentNodeId (variable) of class OPCUA::NodeProperties is not documented.
ERR: /home/codac-dev/ni9157Testing/MARTe2-components/Source/Components/Interfaces/OPCUA/OPCUATypes.h:51: warning: Member parentReferenceNodeId (variable) of class OPCUA::NodeProperties is not documented.
ERR: /home/codac-dev/ni9157Testing/MARTe2-components/Source/Components/Interfaces/OPCUA/OPCUATypes.h:61: warning: Member attr (variable) of class OPCUA::ObjectProperties is not documented.
ERR: /home/codac-dev/ni9157Testing/MARTe2-components/Source/Components/Interfaces/OPCUA/OPCUATypes.h:62: warning: Member nodeId (variable) of class OPCUA::ObjectProperties is not documented.
ERR: /home/codac-dev/ni9157Testing/MARTe2-components/Source/Components/Interfaces/OPCUA/OPCUATypes.h:63: warning: Member nodeName (variable) of class OPCUA::ObjectProperties is not documented.
ERR: /home/codac-dev/ni9157Testing/MARTe2-components/Source/Components/Interfaces/OPCUA/OPCUATypes.h:64: warning: Member parentNodeId (variable) of class OPCUA::ObjectProperties is not documented.
ERR: /home/codac-dev/ni9157Testing/MARTe2-components/Source/Components/Interfaces/OPCUA/OPCUATypes.h:65: warning: Member parentReferenceNodeId (variable) of class OPCUA::ObjectProperties is not documented.
ERR: /home/codac-dev/ni9157Testing/MARTe2-components/Source/Components/DataSources/ProfinetDataSource/ProfinetDataSourceAdapter.h:479: warning: The following parameters of ProfinetDataSourceDriver::ProfinetDataSourceAdapter::SetBaseData(MARTe::uint8 vendorIdHigh, MARTe::uint8 vendorIdLow, MARTe::uint8 deviceIdHigh, MARTe::uint8 deviceIdLow, MARTe::uint8 oemVendorIdHigh, MARTe::uint8 oemVendorIdLow, MARTe::uint8 oemDeviceIdHigh, MARTe::uint8 oemDeviceIdLow, MARTe::StreamString productName, MARTe::uint16 minimumDeviceInterval) are not documented:
Unit test review¶
Date of the review: 06/04/2021
Person who did the review: TODO
Version of source code: c9cb11171f7d139aa8ec78d8d82a0c40ab5bd9e2
Result of coverage tests review: TODO
Result of functional tests review: TODO
Result of review: TODO
Comments: TODO
List of non-conformities:
Functional tests
OK: All public methods are being tested at least once
OK: no errors found.
GTest
ERR: helper did not run.
Unsolved Failing Tests
New Failing Tests
Solved Failing Tests
Coverage
ERR: helper did not run.
Integration test review¶
Date of the review: 06/04/2021
Person who did the review: TODO
Version of source code: c9cb11171f7d139aa8ec78d8d82a0c40ab5bd9e2
Result of review: N/A
List of non-conformities: N/A
Comments: N/A
Acceptance test review¶
Date of the review: 06/04/2021
Person who did the review: TODO
Version of source code: c9cb11171f7d139aa8ec78d8d82a0c40ab5bd9e2
Result of review: N/A
List of non-conformities: N/A
Comments: N/A
#8 Updated by André Neto almost 4 years ago
- Status changed from Code: Impl to Unit: Rev
#9 Updated by André Neto almost 4 years ago
- Assignee changed from Pedro Lourenco to André Neto
#10 Updated by André Neto almost 4 years ago
- Assignee deleted (
André Neto)
#11 Updated by André Neto about 3 years ago
- Status changed from Unit: Rev to New
#12 Updated by André Neto about 3 years ago
- Status changed from New to Unit: Rev
#13 Updated by André Neto over 2 years ago
- Status changed from Unit: Rev to Code: Impl
#14 Updated by André Neto over 2 years ago
- Assignee set to Pedro Lourenco
#15 Updated by André Neto over 1 year ago
- Assignee deleted (
Pedro Lourenco) - Status changed from Code: Impl to New